Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Simplify limitShrink before releasing #5112

Merged
merged 2 commits into from
Jul 9, 2024
Merged

✨ Simplify limitShrink before releasing #5112

merged 2 commits into from
Jul 9, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jul 9, 2024

Description

We align the API of limitShrink with other arbitraries referencing compulsory settings. Instead of asking htem to be provided via an object/record, these options are passed as dedicated parameters.

We follow the same logic for limitShrink.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ✨ Introduce new features
  • Impacts: Changing unpublished signature

We align the API of `limitShrink` with other arbitraries referencing compulsory settings. Instead of asking htem to be provided via an object/record, these options are passed as dedicated parameters.

We follow the same logic for `limitShrink`.
@dubzzz dubzzz enabled auto-merge (squash) July 9, 2024 07:07
Copy link

codesandbox-ci bot commented Jul 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1d73f41:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

github-actions bot commented Jul 9, 2024

👋 A preview of the new documentation is available at: http://668ce2acd4752648da4f5e0a--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.90%. Comparing base (a462acf) to head (1d73f41).
Report is 3 commits behind head on main.

Files Patch % Lines
packages/fast-check/src/arbitrary/limitShrink.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5112      +/-   ##
==========================================
- Coverage   96.90%   96.90%   -0.01%     
==========================================
  Files         218      218              
  Lines       16533    16521      -12     
  Branches     2701     2702       +1     
==========================================
- Hits        16022    16010      -12     
  Misses        511      511              
Flag Coverage Δ
unit-tests 96.90% <83.33%> (-0.01%) ⬇️
unit-tests-18.x-Linux 96.90% <83.33%> (-0.01%) ⬇️
unit-tests-20.x-Linux 96.90% <83.33%> (-0.01%) ⬇️
unit-tests-22.x-Linux 96.90% <83.33%> (-0.01%) ⬇️
unit-tests-latest-Linux 96.90% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 842d225 into main Jul 9, 2024
57 of 58 checks passed
@dubzzz dubzzz deleted the limit-s-2 branch July 9, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant