Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥(jest) Drop deprecated {it,test}Prop #5166

Merged
merged 2 commits into from
Jul 26, 2024
Merged

💥(jest) Drop deprecated {it,test}Prop #5166

merged 2 commits into from
Jul 26, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jul 26, 2024

Description first opened as #5033

💥 Breaking change

The runners itProp and testProp have been deprecated in @fast-check/jest for quite some times. We are dropping them in favor of their recommended new versions: It.prop and test.prop.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: 💥 Breaking change
  • Impacts: Drop deprecated API

**Description**

<!-- Please provide a short description and potentially linked issues
justifying the need for this PR -->

**💥 Breaking change**

The runners `itProp` and `testProp` have been deprecated in
`@fast-check/jest` for quite some times. We are dropping them in favor
of their recommended new versions: `It.prop` and `test.prop`.

<!-- * Your PR is fixing a bug or regression? Check for existing issues
related to this bug and link them -->
<!-- * Your PR is adding a new feature? Make sure there is a related
issue or discussion attached to it -->

<!-- You can provide any additional context to help into understanding
what's this PR is attempting to solve: reproduction of a bug, code
snippets... -->

**Checklist** — _Don't delete this checklist and make sure you do the
following before opening the PR_

- [x] The name of my PR follows [gitmoji](https://gitmoji.dev/)
specification
- [x] My PR references one of several related issues (if any)
- [x] New features or breaking changes must come with an associated
Issue or Discussion
- [x] My PR does not add any new dependency without an associated Issue
or Discussion
- [x] My PR includes bumps details, please run `yarn bump` and flag the
impacts properly
- [x] My PR adds relevant tests and they would have failed without my PR
(when applicable)

<!-- More about contributing at
https://github.com/dubzzz/fast-check/blob/main/CONTRIBUTING.md -->

**Advanced**

<!-- How to fill the advanced section is detailed below! -->

- [x] Category: 💥 Breaking change
- [x] Impacts: Drop deprecated API

<!-- [Category] Please use one of the categories below, it will help us
into better understanding the urgency of the PR -->
<!-- * ✨ Introduce new features -->
<!-- * 📝 Add or update documentation -->
<!-- * ✅ Add or update tests -->
<!-- * 🐛 Fix a bug -->
<!-- * 🏷️ Add or update types -->
<!-- * ⚡️ Improve performance -->
<!-- * _Other(s):_ ... -->

<!-- [Impacts] Please provide a comma separated list of the potential
impacts that might be introduced by this change -->
<!-- * Generated values: Can your change impact any of the existing
generators in terms of generated values, if so which ones? when? -->
<!-- * Shrink values: Can your change impact any of the existing
generators in terms of shrink values, if so which ones? when? -->
<!-- * Performance: Can it require some typings changes on user side?
Please give more details -->
<!-- * Typings: Is there a potential performance impact? In which cases?
-->
@dubzzz dubzzz enabled auto-merge (squash) July 26, 2024 22:48
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 33a6a4e:

Sandbox Source
@fast-check/examples Configuration

@dubzzz dubzzz disabled auto-merge July 26, 2024 22:51
@dubzzz dubzzz enabled auto-merge (squash) July 26, 2024 22:51
Copy link
Contributor

👋 A preview of the new documentation is available at: http://66a429b0c4998274efad4e72--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit 3692ba4 into main Jul 26, 2024
57 checks passed
@dubzzz dubzzz deleted the jest-drop-deprecated branch July 26, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant