Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support UUID versions [1-15] on uuidV #5172

Merged
merged 8 commits into from
Aug 6, 2024
Merged

✨ Support UUID versions [1-15] on uuidV #5172

merged 8 commits into from
Aug 6, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jul 27, 2024

No description provided.

Copy link

codesandbox-ci bot commented Jul 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 657e653:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

👋 A preview of the new documentation is available at: http://66a4983b02b89ecee9008e0f--dubzzz-fast-check.netlify.app

Copy link
Contributor

👋 A preview of the new documentation is available at: http://66a4998807f56fc4b46b318a--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (0cc7b20) to head (657e653).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5172   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         230      230           
  Lines        9260     9262    +2     
  Branches     2713     2714    +1     
=======================================
+ Hits         8779     8781    +2     
  Misses        481      481           
Flag Coverage Δ
unit-tests 94.80% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x-Linux 94.80% <100.00%> (+<0.01%) ⬆️
unit-tests-20.x-Linux 94.80% <100.00%> (+<0.01%) ⬆️
unit-tests-22.x-Linux 94.80% <100.00%> (+<0.01%) ⬆️
unit-tests-latest-Linux 94.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👋 A preview of the new documentation is available at: http://66a4b0c0fa7205e61f655444--dubzzz-fast-check.netlify.app

Copy link
Contributor

github-actions bot commented Aug 6, 2024

👋 A preview of the new documentation is available at: http://66b292c36e00e70080d02493--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit 868f9b1 into main Aug 6, 2024
75 checks passed
@dubzzz dubzzz deleted the dubzzz-patch-3 branch August 6, 2024 22:29
dubzzz added a commit that referenced this pull request Aug 6, 2024
**Description**

This PR adds the ability to customize the versions of the UUIDs produced
by `uuid` without having to rely on its counterpart version `uuidV`. It
paves the way for the future drop of `uuidV`.

Follow-up of #5172

Related to issues: #5104 and #5103

<!-- Please provide a short description and potentially linked issues
justifying the need for this PR -->

<!-- * Your PR is fixing a bug or regression? Check for existing issues
related to this bug and link them -->
<!-- * Your PR is adding a new feature? Make sure there is a related
issue or discussion attached to it -->

<!-- You can provide any additional context to help into understanding
what's this PR is attempting to solve: reproduction of a bug, code
snippets... -->

**Checklist** — _Don't delete this checklist and make sure you do the
following before opening the PR_

- [x] The name of my PR follows [gitmoji](https://gitmoji.dev/)
specification
- [x] My PR references one of several related issues (if any)
- [x] New features or breaking changes must come with an associated
Issue or Discussion
- [x] My PR does not add any new dependency without an associated Issue
or Discussion
- [x] My PR includes bumps details, please run `yarn bump` and flag the
impacts properly
- [x] My PR adds relevant tests and they would have failed without my PR
(when applicable)

<!-- More about contributing at
https://github.com/dubzzz/fast-check/blob/main/CONTRIBUTING.md -->

**Advanced**

<!-- How to fill the advanced section is detailed below! -->

- [x] Category: ✨ Introduce new features
- [x] Impacts: Nothing, except an APi offering more options. Generated
values are unchanged and shrinker behaves the same

<!-- [Category] Please use one of the categories below, it will help us
into better understanding the urgency of the PR -->
<!-- * ✨ Introduce new features -->
<!-- * 📝 Add or update documentation -->
<!-- * ✅ Add or update tests -->
<!-- * 🐛 Fix a bug -->
<!-- * 🏷️ Add or update types -->
<!-- * ⚡️ Improve performance -->
<!-- * _Other(s):_ ... -->

<!-- [Impacts] Please provide a comma separated list of the potential
impacts that might be introduced by this change -->
<!-- * Generated values: Can your change impact any of the existing
generators in terms of generated values, if so which ones? when? -->
<!-- * Shrink values: Can your change impact any of the existing
generators in terms of shrink values, if so which ones? when? -->
<!-- * Performance: Can it require some typings changes on user side?
Please give more details -->
<!-- * Typings: Is there a potential performance impact? In which cases?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant