Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ Deprecate uuidV in favor of uuid #5189

Merged
merged 2 commits into from
Aug 6, 2024
Merged

🗑️ Deprecate uuidV in favor of uuid #5189

merged 2 commits into from
Aug 6, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Aug 6, 2024

Description

Deprecating uuidV in favor of uuid. No need to have both now that uuid also offers ways to customize the generated versions (see #5188).

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: Deprecate code
  • Impacts: Will be dropped on next major

@dubzzz dubzzz enabled auto-merge (squash) August 6, 2024 22:53
Copy link

codesandbox-ci bot commented Aug 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2767f20:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

github-actions bot commented Aug 6, 2024

👋 A preview of the new documentation is available at: http://66b2aa5ef99cc206a3c76baa--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (868f9b1) to head (2767f20).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5189   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         230      230           
  Lines        9262     9262           
  Branches     2713     2706    -7     
=======================================
  Hits         8781     8781           
  Misses        481      481           
Flag Coverage Δ
unit-tests 94.80% <ø> (ø)
unit-tests-18.x-Linux 94.80% <ø> (ø)
unit-tests-20.x-Linux ?
unit-tests-22.x-Linux ?
unit-tests-latest-Linux ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 9538ee1 into main Aug 6, 2024
59 checks passed
@dubzzz dubzzz deleted the deprecate-uuid branch August 6, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant