Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Support npm publish on other tags #5190

Merged
merged 1 commit into from
Aug 7, 2024
Merged

👷 Support npm publish on other tags #5190

merged 1 commit into from
Aug 7, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Aug 7, 2024

Description

Until now our publication script was unable to publish on a tag not being "latest" (the default when no tag specified). More precisely, unable except changing the script before publishing.

With that change we make it automatic. Things on main will still be issued on latest, things on next- will be flagged for next and all the rest (normally backports) will fall in the legacy bucket.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: Build chain
  • Impacts: Publication

Until now our publication script was unable to publish on a tag not being "latest" (the default when no tag specified). More precisely, unable except changing the script before publishing.

With that change we make it automatic. Things on main will still be issued on latest, things on next- will be flagged for next and all the rest (normally backports) will fall in the legacy bucket.
Copy link

codesandbox-ci bot commented Aug 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ddd8cba:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

github-actions bot commented Aug 7, 2024

👋 A preview of the new documentation is available at: http://66b324dbd354ea87c73f369d--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (868f9b1) to head (ddd8cba).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5190      +/-   ##
==========================================
- Coverage   94.80%   94.73%   -0.08%     
==========================================
  Files         230      231       +1     
  Lines        9262     9320      +58     
  Branches     2713     2731      +18     
==========================================
+ Hits         8781     8829      +48     
- Misses        481      491      +10     
Flag Coverage Δ
unit-tests 94.73% <ø> (-0.08%) ⬇️
unit-tests-18.x-Linux 94.73% <ø> (-0.08%) ⬇️
unit-tests-20.x-Linux 94.73% <ø> (-0.08%) ⬇️
unit-tests-22.x-Linux 94.73% <ø> (-0.08%) ⬇️
unit-tests-latest-Linux 94.73% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit e00f4d6 into main Aug 7, 2024
74 of 75 checks passed
@dubzzz dubzzz deleted the better-publish branch August 7, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant