Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️(vitest) Add missing types on exported #5200

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Aug 10, 2024

Description

In order to toggle ON the flag isolatedDeclarations and allow us to use something else than tsc to build our project (not sure we will do one day), we start to make some types more explicit on our exported symbols.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ♻️ Refactoring
  • Impacts: None

In order to toggle ON the flag `isolatedDeclarations` and allow us to use something else than tsc to build our project (not sure we will do one day), we start to make some types more explicit on our exported symbols.
Copy link

codesandbox-ci bot commented Aug 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6809edd:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

👋 A preview of the new documentation is available at: http://66b72cf1a5564dfdb32675e7--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (1801d1a) to head (6809edd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5200   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         231      231           
  Lines        9320     9320           
  Branches     2731     2730    -1     
=======================================
  Hits         8829     8829           
  Misses        491      491           
Flag Coverage Δ
unit-tests 94.73% <ø> (ø)
unit-tests-18.x-Linux 94.73% <ø> (ø)
unit-tests-20.x-Linux 94.73% <ø> (ø)
unit-tests-22.x-Linux 94.73% <ø> (ø)
unit-tests-latest-Linux 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz enabled auto-merge (squash) August 10, 2024 09:08
@dubzzz dubzzz merged commit c2cf432 into main Aug 10, 2024
59 checks passed
@dubzzz dubzzz deleted the missing-types-vitest branch August 10, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant