Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ—‘οΈ Deprecate bigInt's alternatives #5238

Merged
merged 6 commits into from
Aug 25, 2024
Merged

πŸ—‘οΈ Deprecate bigInt's alternatives #5238

merged 6 commits into from
Aug 25, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Aug 24, 2024

Description

Starting at 3.22.0 the usage of bigIntN, bigUintN and bigUint will be discouraged. We instead recommend calling bigInt with appropriate min and max values when relevant.

Checklist β€” Don't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: πŸ—‘οΈ Depreciate features
  • Impacts: Less built-in in future majors

Copy link

changeset-bot bot commented Aug 24, 2024

⚠️ No Changeset found

Latest commit: a7041e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Aug 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7041e1:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

πŸ‘‹ A preview of the new documentation is available at: http://66c9c0094600d7c88ad94fcb--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.32%. Comparing base (19f1bb1) to head (a7041e1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5238   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files         234      234           
  Lines       10414    10414           
  Branches     2774     2774           
=======================================
  Hits         9927     9927           
  Misses        487      487           
Flag Coverage Ξ”
unit-tests 95.32% <ΓΈ> (ΓΈ)
unit-tests-18.x-Linux 95.32% <ΓΈ> (ΓΈ)
unit-tests-20.x-Linux 95.32% <ΓΈ> (ΓΈ)
unit-tests-22.x-Linux 95.32% <ΓΈ> (ΓΈ)
unit-tests-latest-Linux 95.32% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

πŸ‘‹ A preview of the new documentation is available at: http://66cae308616fe4d0243c84d8--dubzzz-fast-check.netlify.app

Copy link
Contributor

πŸ‘‹ A preview of the new documentation is available at: http://66cae78c361cdfd215e6ad26--dubzzz-fast-check.netlify.app

@dubzzz dubzzz changed the title Update bigIntN.ts πŸ—‘οΈ Deprecate bigInt's alternatives Aug 25, 2024
Copy link
Contributor

πŸ‘‹ A preview of the new documentation is available at: http://66cb087fbd7394f14ce20c05--dubzzz-fast-check.netlify.app

@dubzzz dubzzz enabled auto-merge (squash) August 25, 2024 10:36
@dubzzz dubzzz merged commit 1baccc5 into main Aug 25, 2024
59 checks passed
@dubzzz dubzzz deleted the dubzzz-patch-1 branch August 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant