Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Resist even more to external poisoning for string #5327

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Oct 10, 2024

Description

string used to be pretty reliable against poisoning and still is. But when used in some context such as the result of another generated value (in the case of .chain or fc.gen) it can expose users to unability to compute itself if a poisoning occured in-between.

As such this PR makes it even more reliable.

Thanks to that PR, string arbitrary should be able to better support an ustable environment with some globals being altered or dropped.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: 🐛 Fix a bug
  • Impacts: Making fast-check more reliable

`string` used to be pretty reliable against poisoning and still is. But when used in some context such as the result of another generated value (in the case of `.chain` or `fc.gen`) it can expose users to unability to compute itself if a poisoning occured in-between.

As such this PR makes it even more reliable.

Thanks to that PR, `string` arbitrary should be able to better support an ustable environment with some globals being altered or dropped.
Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: e61c1fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fast-check Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e61c1fa:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

👋 A preview of the new documentation is available at: http://6707841f8038329bd5278403--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.29%. Comparing base (96db498) to head (e61c1fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/fast-check/src/utils/globals.ts 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5327      +/-   ##
==========================================
- Coverage   95.35%   95.29%   -0.06%     
==========================================
  Files         234      234              
  Lines       10414    10433      +19     
  Branches     2774     2778       +4     
==========================================
+ Hits         9930     9942      +12     
- Misses        484      491       +7     
Flag Coverage Δ
unit-tests 95.29% <84.61%> (-0.06%) ⬇️
unit-tests-18.x-Linux 95.29% <84.61%> (-0.06%) ⬇️
unit-tests-20.x-Linux 95.29% <84.61%> (-0.03%) ⬇️
unit-tests-22.x-Linux 95.29% <84.61%> (-0.03%) ⬇️
unit-tests-latest-Linux 95.29% <84.61%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 0793dac into main Oct 10, 2024
71 of 73 checks passed
@dubzzz dubzzz deleted the ext-pois branch October 10, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant