🐛 Resist even more to external poisoning for string
#5327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
string
used to be pretty reliable against poisoning and still is. But when used in some context such as the result of another generated value (in the case of.chain
orfc.gen
) it can expose users to unability to compute itself if a poisoning occured in-between.As such this PR makes it even more reliable.
Thanks to that PR,
string
arbitrary should be able to better support an ustable environment with some globals being altered or dropped.Checklist — Don't delete this checklist and make sure you do the following before opening the PR
yarn bump
and flag the impacts properlyAdvanced