Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷(vitest) Move to Vitest #5350

Merged
merged 4 commits into from
Oct 21, 2024
Merged

👷(vitest) Move to Vitest #5350

merged 4 commits into from
Oct 21, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Oct 21, 2024

Description

Change our test runner to Vitest.

Jest is great but it's partial support for ESM is putting us in troubles. As such we passed fast-check to Vitest a while ago and want to unify all others so that we preserve a unique test runner in our CI.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: 👷 Build tools & CI
  • Impacts: Test runner

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 5d4f146

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@fast-check/vitest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Oct 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d4f146:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

👋 A preview of the new documentation is available at: http://67169b45907aac9b7b285500--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (331814a) to head (5d4f146).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5350   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         234      234           
  Lines       10433    10433           
  Branches     2777     2779    +2     
=======================================
  Hits         9942     9942           
  Misses        491      491           
Flag Coverage Δ
unit-tests 95.29% <ø> (ø)
unit-tests-18.x-Linux 95.29% <ø> (ø)
unit-tests-20.x-Linux 95.29% <ø> (ø)
unit-tests-22.x-Linux 95.29% <ø> (ø)
unit-tests-latest-Linux 95.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👋 A preview of the new documentation is available at: http://67169e13c89234a94bf85ecf--dubzzz-fast-check.netlify.app

@dubzzz dubzzz enabled auto-merge (squash) October 21, 2024 22:50
Copy link
Contributor

👋 A preview of the new documentation is available at: http://6716db2df8be3edead71ea90--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit a35ec53 into main Oct 21, 2024
57 checks passed
@dubzzz dubzzz deleted the vi-vi branch October 21, 2024 22:53
dubzzz added a commit that referenced this pull request Oct 22, 2024
Follow-up of #5350.

We forgot to drop some unneeded configuration files when moving to Vitest.
dubzzz added a commit that referenced this pull request Oct 22, 2024
**Description**

<!-- Please provide a short description and potentially linked issues
justifying the need for this PR -->

Follow-up of #5350.

We forgot to drop some unneeded configuration files when moving to
Vitest.

<!-- * Your PR is fixing a bug or regression? Check for existing issues
related to this bug and link them -->
<!-- * Your PR is adding a new feature? Make sure there is a related
issue or discussion attached to it -->

<!-- You can provide any additional context to help into understanding
what's this PR is attempting to solve: reproduction of a bug, code
snippets... -->

**Checklist** — _Don't delete this checklist and make sure you do the
following before opening the PR_

- [x] The name of my PR follows [gitmoji](https://gitmoji.dev/)
specification
- [x] My PR references one of several related issues (if any)
- [x] New features or breaking changes must come with an associated
Issue or Discussion
- [x] My PR does not add any new dependency without an associated Issue
or Discussion
- [x] My PR includes bumps details, please run `yarn bump` and flag the
impacts properly
- [x] My PR adds relevant tests and they would have failed without my PR
(when applicable)

<!-- More about contributing at
https://github.com/dubzzz/fast-check/blob/main/CONTRIBUTING.md -->

**Advanced**

<!-- How to fill the advanced section is detailed below! -->

- [x] Category: 👷 Build & CI
- [x] Impacts: Drop unneeded devDependencies

<!-- [Category] Please use one of the categories below, it will help us
into better understanding the urgency of the PR -->
<!-- * ✨ Introduce new features -->
<!-- * 📝 Add or update documentation -->
<!-- * ✅ Add or update tests -->
<!-- * 🐛 Fix a bug -->
<!-- * 🏷️ Add or update types -->
<!-- * ⚡️ Improve performance -->
<!-- * _Other(s):_ ... -->

<!-- [Impacts] Please provide a comma separated list of the potential
impacts that might be introduced by this change -->
<!-- * Generated values: Can your change impact any of the existing
generators in terms of generated values, if so which ones? when? -->
<!-- * Shrink values: Can your change impact any of the existing
generators in terms of shrink values, if so which ones? when? -->
<!-- * Performance: Can it require some typings changes on user side?
Please give more details -->
<!-- * Typings: Is there a potential performance impact? In which cases?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant