Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for string-unit on object/anything arbitrary #5366

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Oct 25, 2024

Description

The unit field has been added pretty recently to string in order to offer ways for our users to control in a more granular way what kind of "character" they would like to be generated for their strings. In order not to mix "character" with the characters in JavaScript and to allow any feasible grapheme or combination of code-points to be a valid "character" we refer to them as "unit".

This PR adds supports for units of strings from object builders.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ✨ Introduce new features
  • Impacts: New flags for finer control on some arbitraries

The `unit` field has been added pretty recently to `string` in order to offer ways for our users to control in a more granular way what kind of "character" they would like to be generated for their strings. In order not to mix "character" with the characters in JavaScript and to allow any feasible grapheme or combination of code-points to be a valid "character" we refer to them as "unit".

This PR adds supports for units of strings from object builders.
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: bd0c1fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fast-check Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Oct 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bd0c1fb:

Sandbox Source
@fast-check/examples Configuration

@dubzzz dubzzz enabled auto-merge (squash) October 25, 2024 16:54
Copy link
Contributor

👋 A preview of the new documentation is available at: http://671bce9d0a7e7c802fb1b966--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit 50c4f2a into main Oct 25, 2024
55 checks passed
@dubzzz dubzzz deleted the unit-obj branch October 25, 2024 17:01
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (0777214) to head (bd0c1fb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5366   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         234      234           
  Lines       10433    10433           
  Branches     2778     2778           
=======================================
  Hits         9942     9942           
  Misses        491      491           
Flag Coverage Δ
unit-tests 95.29% <100.00%> (ø)
unit-tests-18.x-Linux 95.29% <100.00%> (ø)
unit-tests-20.x-Linux 95.29% <100.00%> (ø)
unit-tests-22.x-Linux 95.29% <100.00%> (ø)
unit-tests-latest-Linux 95.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant