Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅(vitest) Add retry for Node 23 #5384

Merged
merged 1 commit into from
Oct 29, 2024
Merged

✅(vitest) Add retry for Node 23 #5384

merged 1 commit into from
Oct 29, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Oct 29, 2024

Retries are needed for now against Node 23. There is an open ticket on V8 side (see https://issues.chromium.org/issues/374285493) and one on Node side (see nodejs/node#54918) regarding hanging issues of Node 23.

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: f079973

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f079973:

Sandbox Source
@fast-check/examples Configuration

@dubzzz dubzzz enabled auto-merge (squash) October 29, 2024 21:24
Copy link
Contributor

👋 A preview of the new documentation is available at: http://672152f48e16a684b81974aa--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (003eb2e) to head (f079973).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5384   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files         234      234           
  Lines       10478    10478           
  Branches     2795     2795           
=======================================
  Hits         9983     9983           
  Misses        495      495           
Flag Coverage Δ
unit-tests 95.27% <ø> (ø)
unit-tests-18.x-Linux 95.27% <ø> (+0.04%) ⬆️
unit-tests-20.x-Linux 95.27% <ø> (ø)
unit-tests-22.x-Linux 95.27% <ø> (ø)
unit-tests-latest-Linux 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 4f42764 into main Oct 29, 2024
57 checks passed
@dubzzz dubzzz deleted the dubzzz-patch-2 branch October 29, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant