Add the timeout flag #131
Merged
Add the timeout flag #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducaale
reviewed
Apr 22, 2021
blyxxyz
reviewed
Apr 23, 2021
src/main.rs
Outdated
Comment on lines
78
to
87
| let timeout = if let Some(timeout) = args.timeout { | ||
| let timeout = timeout.as_duration(); | ||
| if timeout == Duration::default() { | ||
| None | ||
| } else { | ||
| Some(timeout) | ||
| } | ||
| } else { | ||
| None | ||
| }; |
There was a problem hiding this comment.
Maybe this logic could go inside as_duration(), and that could return an Option<Duration> instead?
blyxxyz
approved these changes
Apr 24, 2021
Comment on lines
+78
to
+81
| let timeout = args | ||
| .timeout | ||
| .map(|t| t.as_duration()) | ||
| .filter(|t| t != &Duration::from_nanos(0)); |
There was a problem hiding this comment.
Nice improvement!
I still think it would make a bit more sense to have this inside as_duration() but it doesn't really matter.
|
Change the newline of |
|
@sorairolake would you like to implement the optional changes requested by @blyxxyz before we merge this? Edit: On second thought, I think this could be done outside of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #4