Add support for Digest authentication #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also handle digest auth in session + a little bit of refactoring for auth.rs
|
Now that |
ducaale
commented
Sep 14, 2021
ducaale
commented
Sep 14, 2021
ducaale
commented
Sep 28, 2021
This reverts commit a635aa6.
also changed Context to be a black box
blyxxyz
requested changes
Nov 14, 2021
| @@ -2197,6 +2244,122 @@ fn warns_if_config_is_invalid() { | |||
| .success(); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
Could you additionally write a test against httpbin's digest endpoint, to make sure it works with a real implementation?
| @@ -135,11 +135,9 @@ pub struct Cli { | |||
| #[structopt(skip)] | |||
| pub is_session_read_only: bool, | |||
|
|
|||
| // Currently deprecated in favor of --bearer, un-hide if new auth types are introduced | |||
There was a problem hiding this comment.
We should probably hide --bearer now
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
blyxxyz
approved these changes
Nov 14, 2021
blyxxyz
reviewed
Nov 14, 2021
Comment on lines
-161
to
+166
| /// Authenticate as USER with PASS. PASS will be prompted if missing. | ||
| /// Authenticate as USER with PASS or with token. | ||
| /// | ||
| /// Use a trailing colon (i.e. `USER:`) to authenticate with just a username. | ||
| /// PASS will be prompted if missing. Use a trailing colon (i.e. `USER:`) | ||
| /// to authenticate with just a username. | ||
| /// | ||
| /// if --auth-type=bearer then --auth expects a token | ||
| /// {n}{n}{n} | ||
| #[structopt(short = "a", long, value_name = "USER[:PASS]")] | ||
| #[structopt(short = "a", long, value_name = "USER[:PASS] | token")] |
There was a problem hiding this comment.
I'd capitalize TOKEN here, and write the last line as TOKEN is expected if `--auth-type=bearer`..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduces a middleware system "inspired" by https://truelayer.com/blog/adding-middleware-support-to-rust-reqwest.
Ticks another item from #4.