Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expand_cidr function #3

Closed
wants to merge 4 commits into from
Closed

Add expand_cidr function #3

wants to merge 4 commits into from

Conversation

hrbrmstr
Copy link

@hrbrmstr hrbrmstr commented Dec 14, 2024 •
edited
Loading

Added:

  • bool IsCIDR() to test whether there is a CIDR component
  • void INetFunctions::ExpandCIDR(DataChunk & args, ExpressionState & state, Vector & result) to perform the CIDR expansion
  • file: test_inet_cidr_expansion.test with IPv4 and IPv6 tests

I can make any other changes necessary

@hrbrmstr hrbrmstr changed the title merging in from branch Add expand_cidr function Dec 14, 2024
@hrbrmstr hrbrmstr mentioned this pull request Dec 14, 2024
Open
@hannes hannes requested a review from Mytherin January 6, 2025 12:05
@Mytherin
Copy link
Contributor

Mytherin commented Jan 6, 2025

Closing as this seems to be the same PR as #5

@Mytherin Mytherin closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Awaiting requested review from Mytherin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrbrmstr @Mytherin