Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest duckdb, absorb patches #247

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Bump to latest duckdb, absorb patches #247

merged 3 commits into from
Aug 26, 2024

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Aug 21, 2024

There are some issues with the tests performed by Linux.yml, that needs to be looked at.

Note that some might be already there since the move to duckdb v1.0.0.

Given these are preexisting, and bumping version do not preclude compilation / problem is minor, I think this can go in independently.

@carlopi carlopi changed the title Bump to latest duckdb, absort patches Bump to latest duckdb, absorb patches Aug 21, 2024
@carlopi
Copy link
Contributor Author

carlopi commented Aug 21, 2024

Example of the failures in Linux.yml:

[27/89] (30%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...
Query unexpectedly failed! (/__w/postgres_scanner/postgres_scanner/test/sql/storage/attach_case_sensitive_columns.test:42)!
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
================================================================================
UPDATE s.tbl_with_case_sensitive_columns SET "MyColumn_1"=84;
================================================================================
Invalid Error: Failed to prepare COPY "
	COPY (SELECT ctid FROM "public"."tbl_with_case_sensitive_columns" ) TO STDOUT (FORMAT binary);
	": ERROR:  current transaction is aborted, commands ignored until end of transaction block
unittest is a Catch v2.13.7 host application.
Run with -? for options
-------------------------------------------------------------------------------
/__w/postgres_scanner/postgres_scanner/test/sql/storage/
attach_case_sensitive_columns.test
-------------------------------------------------------------------------------
/__w/postgres_scanner/postgres_scanner/duckdb/test/sqlite/test_sqllogictest.cpp:219
...............................................................................
/__w/postgres_scanner/postgres_scanner/test/sql/storage/attach_case_sensitive_columns.test:42: FAILED:
explicitly with message:
  0
================================================================================
[32/89] (35%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...-------------------------------------------------------------------------------
Query unexpectedly failed! (/__w/postgres_scanner/postgres_scanner/test/sql/storage/attach_types_multidimensional_array.test:126)!
================================================================================
INSERT INTO two_dimensional_array FROM two_dimensional_array;
================================================================================
Invalid Error: Failed to prepare COPY "
	COPY (SELECT "i" FROM "public"."two_dimensional_array" ) TO STDOUT (FORMAT binary);
	": ERROR:  current transaction is aborted, commands ignored until end of transaction block
/__w/postgres_scanner/postgres_scanner/test/sql/storage/
attach_types_multidimensional_array.test
-------------------------------------------------------------------------------
/__w/postgres_scanner/postgres_scanner/duckdb/test/sqlite/test_sqllogictest.cpp:219
...............................................................................
/__w/postgres_scanner/postgres_scanner/test/sql/storage/attach_types_multidimensional_array.test:126: FAILED:
explicitly with message:
  0

@carlopi carlopi requested a review from Mytherin August 21, 2024 14:06
@carlopi
Copy link
Contributor Author

carlopi commented Aug 21, 2024

Test will not make any more progress (it's at 56/90 for an hour now, and will eventually go in timeout from there):

================================================================================
Query unexpectedly failed! (/__w/postgres_scanner/postgres_scanner/test/sql/storage/attach_update.test:22)!
================================================================================
UPDATE s1.test SET i = i + 1;
================================================================================
Invalid Error: Failed to prepare COPY "
	COPY (SELECT "i", ctid FROM "public"."test" ) TO STDOUT (FORMAT binary);
	": ERROR:  current transaction is aborted, commands ignored until end of transaction block
[47/89] (52%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...-------------------------------------------------------------------------------
/__w/postgres_scanner/postgres_scanner/test/sql/storage/attach_update.test
-------------------------------------------------------------------------------
/__w/postgres_scanner/postgres_scanner/duckdb/test/sqlite/test_sqllogictest.cpp:219
...............................................................................
/__w/postgres_scanner/postgres_scanner/test/sql/storage/attach_update.test:22: FAILED:
explicitly with message:
  0
[48/89] (53%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...
[49/89] (55%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...
[50/89] (56%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...
[51/89] (57%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...
[52/89] (58%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...
[53/89] (59%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...
[54/89] (60%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...
[55/89] (61%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...
[56/89] (62%): /__w/postgres_scanner/postgres_scanner/test/sql/storage/attach...

At this moment failure is expected.

@Mytherin Mytherin merged commit d0e0115 into duckdb:main Aug 26, 2024
15 of 16 checks passed
@Mytherin
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants