Update arrow requirement from 40 to 41 (#172)

* Update arrow requirement from 40 to 41

Updates the requirements on [arrow](https://github.com/apache/arrow-rs) to permit the latest version.
- [Changelog](https://github.com/apache/arrow-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/apache/arrow-rs/commits)

---
updated-dependencies:
- dependency-name: arrow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* disable clone clippy

* remove as_string

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: wangfenjin <wangfenj@gmail.com>

Cargo.toml

@@ -56,7 +56,7 @@ memchr = "2.3"
 uuid = { version = "1.0", optional = true }
 smallvec = "1.6.1"
 cast = { version = "0.3", features = ["std"] }
-arrow = { version = "40", default-features = false, features = ["prettyprint", "ffi"] }
+arrow = { version = "41", default-features = false, features = ["prettyprint", "ffi"] }
 rust_decimal = "1.14"
 strum = { version = "0.24", features = ["derive"] }
 r2d2 = { version = "0.8.9", optional = true }

duckdb-loadable-macros/src/lib.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::redundant_clone)]
 use proc_macro2::Ident;
 
 use syn::{parse_macro_input, spanned::Spanned, Item};

libduckdb-sys/Cargo.toml

@@ -39,4 +39,4 @@ serde_json = { version = "1.0" }
 tar = "0.4.38"
 
 [dev-dependencies]
-arrow = { version = "40", default-features = false, features = ["ffi"] }
+arrow = { version = "41", default-features = false, features = ["ffi"] }

src/vtab/function.rs

@@ -1,5 +1,4 @@
 use super::{
-    as_string,
     ffi::{
         duckdb_bind_add_result_column, duckdb_bind_get_extra_info, duckdb_bind_get_parameter,
         duckdb_bind_get_parameter_count, duckdb_bind_info, duckdb_bind_set_bind_data, duckdb_bind_set_cardinality,
@@ -29,17 +28,19 @@ impl BindInfo {
     ///  * `name`: The name of the column
     ///  * `type`: The logical type of the column
     pub fn add_result_column(&self, column_name: &str, column_type: LogicalType) {
+        let c_str = CString::new(column_name).unwrap();
         unsafe {
-            duckdb_bind_add_result_column(self.ptr, as_string!(column_name), column_type.ptr);
+            duckdb_bind_add_result_column(self.ptr, c_str.as_ptr() as *const c_char, column_type.ptr);
         }
     }
     /// Report that an error has occurred while calling bind.
     ///
     /// # Arguments
     ///  * `error`: The error message
     pub fn set_error(&self, error: &str) {
+        let c_str = CString::new(error).unwrap();
         unsafe {
-            duckdb_bind_set_error(self.ptr, as_string!(error));
+            duckdb_bind_set_error(self.ptr, c_str.as_ptr() as *const c_char);
         }
     }
     /// Sets the user-provided bind data in the bind object. This object can be retrieved again during execution.
@@ -157,7 +158,8 @@ impl InitInfo {
     /// # Arguments
     /// * `error`: The error message
     pub fn set_error(&self, error: &str) {
-        unsafe { duckdb_init_set_error(self.0, as_string!(error)) }
+        let c_str = CString::new(error).unwrap();
+        unsafe { duckdb_init_set_error(self.0, c_str.as_ptr() as *const c_char) }
     }
 }
 
@@ -298,8 +300,9 @@ impl FunctionInfo {
     /// # Arguments
     ///  * `error`: The error message
     pub fn set_error(&self, error: &str) {
+        let c_str = CString::new(error).unwrap();
         unsafe {
-            duckdb_function_set_error(self.0, as_string!(error));
+            duckdb_function_set_error(self.0, c_str.as_ptr() as *const c_char);
         }
     }
     /// Gets the bind data set by [`BindInfo::set_bind_data`] during the bind.

src/vtab/mod.rs

@@ -27,15 +27,6 @@ pub use vector::{FlatVector, Inserter, ListVector, StructVector, Vector};
 
 use ffi::{duckdb_bind_info, duckdb_data_chunk, duckdb_function_info, duckdb_init_info};
 
-/// Returns a `*const c_char` pointer to the given string
-#[macro_export]
-macro_rules! as_string {
-    ($x:expr) => {
-        std::ffi::CString::new($x).expect("c string").as_ptr().cast::<c_char>()
-    };
-}
-pub(crate) use as_string;
-
 use ffi::duckdb_malloc;
 use std::mem::size_of;