Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to pass any setting to DuckDB config #238

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

mlafeldt
Copy link
Contributor

Most settings from https://duckdb.org/docs/sql/configuration.html currently can't be configured since the set method is private. This PR adds a new with method that makes it easy to compose a config with arbitrary settings.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bff098) 59.09% compared to head (29b5844) 59.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   59.09%   59.36%   +0.26%     
==========================================
  Files          36       36              
  Lines        2100     2104       +4     
==========================================
+ Hits         1241     1249       +8     
+ Misses        859      855       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mytherin
Copy link
Contributor

Mytherin commented Dec 1, 2023

Thanks for the PR! Could we add a test with an invalid setting as well?

@mlafeldt
Copy link
Contributor Author

mlafeldt commented Dec 1, 2023

Thanks for the PR! Could we add a test with an invalid setting as well?

Absolutely! Done.

@Mytherin Mytherin merged commit 0277fb3 into duckdb:main Dec 1, 2023
4 checks passed
@Mytherin
Copy link
Contributor

Mytherin commented Dec 1, 2023

Thanks!

@mlafeldt mlafeldt deleted the config-with branch December 1, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants