Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add origin to PrivacyPro onboarding #5002

Merged

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Sep 11, 2024

Task/Issue URL: https://app.asana.com/0/0/1208267346523762/f

Description

Add origin to PrivacyPro onboarding URL

Steps to test this PR

Pre steps

  • Change privacy-config URL for PRIVACY_REMOTE_CONFIG_URL = "https://jsonblob.com/api/1279046082855034880"
  • Make sure you remove DuckDuckGo folder under Downloads directory

privacyPro dialog (Learn More)

  • Change JsonBlob variant filters in order to assign mr which is the experimental variant
    • under experimentalVariants set privacyProEligible to false/true for mr and mq weight to 0 so you get assigned mr
    "filters": {
      "privacyProEligible": false/true
    }
  • Fresh install
  • Go to a site
  • Dismiss trackers dialog
  • Open a new tab
  • End dialog will appear
  • Dismiss dialog tapping in High Five! button
  • Check new privacy pro message is shown
  • Tap on "learn more"
  • Check you are redirected to Privacy Pro with new origin ([funnel_pro_android_onboarding](https://duckduckgo.com/pro?origin=funnel_pro_android_onboarding))

No UI changes

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on Graphite Graphite

@nalcalag nalcalag marked this pull request as ready for review September 11, 2024 13:53
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nalcalag nalcalag merged commit f2edb92 into develop Sep 11, 2024
8 checks passed
@nalcalag nalcalag deleted the feature/noelia/add_origin_to_privacy_pro_onboarding branch September 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants