Omnibar Refactor: Extract methods to OmnibarView #5025
Merged
+336
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @malmstein and the rest of your teammates on |
malmstein
force-pushed
the
feature/david/09-16-omnibar_refactor_move_methods_to_legacy_omnibar
branch
from
b4d25c4
to
603ff51
Compare
malmstein
force-pushed
the
feature/david/09-16-omnibar_refactor_extract_methods_to_omnibarview
branch
from
2433db3
to
6e219ca
Compare
malmstein
merged commit 76f310e
into
feature/david/09-16-omnibar_refactor_move_methods_to_legacy_omnibar
0 of 4 checks passed
malmstein
deleted the
feature/david/09-16-omnibar_refactor_extract_methods_to_omnibarview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208319036523674/f
Description
Moving methods out of BTF. Preparation for Feature flag