Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RMF unique pixel: adding tag as part of unique type #5207

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Oct 29, 2024

Task/Issue URL: https://app.asana.com/0/1207619243206445/1208647599954669/f

Description

When sending unique RMF pixel, include tag so we can differentiate between other remote message pixels.

Steps to test this PR

Feature 1

  • update remote message service to consume https://www.jsonblob.com/api/1284189194082443264
  • fresh install, and skip onboarding
  • on NTP you will see RMF card
  • ensure unique shown pixel is sent
  • update config at https://www.jsonblob.com/1284189194082443264, removing the message just displayed and bump version
  • restart the app
  • on NTP you will see a new RMF card
  • ensure unique shown pixel is sent
  • restart the app
  • on NTP you still see the previous RMF card
  • ensure unique shown is not sent

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @cmonfortep and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks @cmonfortep !

@cmonfortep cmonfortep merged commit 802d7ed into develop Oct 30, 2024
9 checks passed
@cmonfortep cmonfortep deleted the feature/cristian/rmf/fix_unique_pixel branch October 30, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants