Apple client send and receive support for crash report cohort IDs (CRCIDs) #3228
jdjacksonpr.yml
on: pull_request
Run SwiftLint
34s
Run unit tests (macOS)
4m 58s
Run unit tests (iOS)
4m 8s
Annotations
13 errors, 14 warnings, and 6 notices
|
Run SwiftLint:
Sources/Crashes/CrashReportSender.swift#L24
TODOs should be resolved (This should _not_ be optional) (todo)
|
|
Run SwiftLint:
Sources/Crashes/CrashReportSender.swift#L69
TODOs should be resolved (Why do we straight-up print th...) (todo)
|
|
Run SwiftLint:
Sources/Crashes/CrashCollection.swift#L210
TODOs should be resolved (This should really be its own ...) (todo)
|
|
Run SwiftLint:
Sources/Crashes/CrashCollection.swift#L45
Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
|
|
Run SwiftLint:
Tests/CrashesTests/CrashCollectionTests.swift#L106
Lines should not have trailing whitespace (trailing_whitespace)
|
|
Run SwiftLint:
Tests/CrashesTests/CrashCollectionTests.swift#L125
Lines should not have trailing whitespace (trailing_whitespace)
|
|
Run SwiftLint:
Tests/CrashesTests/CrashCollectionTests.swift#L127
Lines should not have trailing whitespace (trailing_whitespace)
|
|
Run SwiftLint:
Tests/CrashesTests/CrashCollectionTests.swift#L130
Lines should not have trailing whitespace (trailing_whitespace)
|
|
Run SwiftLint:
Tests/CrashesTests/CrashCollectionTests.swift#L137
Lines should not have trailing whitespace (trailing_whitespace)
|
|
Run SwiftLint:
Tests/CrashesTests/CrashCollectionTests.swift#L157
Lines should not have trailing whitespace (trailing_whitespace)
|
|
SettingsRegularSyncResponseHandlerTests.testThatSettingStateIsApplied:
.build/arm64-apple-macosx/debug/SyncDataProvidersTests.build/SettingsRegularSyncResponseHandlerTests.d#L1
/Users/runner/work/BrowserServicesKit/BrowserServicesKit/Tests/SyncDataProvidersTests/Settings/SettingsRegularSyncResponseHandlerTests.swift:89 - XCTAssertEqual failed: ("nil") is not equal to ("Optional("remote")")
|
|
Run unit tests (macOS):
Tests/SyncDataProvidersTests/Settings/SettingsRegularSyncResponseHandlerTests.swift#L89
testThatSettingStateIsApplied, XCTAssertEqual failed: ("nil") is not equal to ("Optional("remote")")
|
|
Run unit tests (macOS)
Process completed with exit code 1.
|
|
Run SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Run unit tests (iOS):
DerivedData/Build/Products/Debug-iphonesimulator/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Run unit tests (macOS):
CoreData#L1
Multiple NSEntityDescriptions claim the NSManagedObject subclass 'DailyBlockedTrackersEntity' so +entity is unable to disambiguate.
|
|
Run unit tests (macOS):
CoreData#L1
'DailyBlockedTrackersEntity' (0x6000019f08f0) from NSManagedObjectModel (0x6000048e7980) claims 'DailyBlockedTrackersEntity'.
|
|
Run unit tests (macOS):
Sources/Navigation/DistributedNavigationDelegate.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
|
Run unit tests (macOS):
Sources/Navigation/Extensions/WKErrorExtension.swift#L67
extension declares a conformance of imported type 'WKError' to imported protocol 'LocalizedError'; this will not behave correctly if the owners of 'WebKit' introduce this conformance in the future
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequest
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterDidStartNavigation
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterWillStartNavigation
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureBeforeWillStartNavigation
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequest
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestWithData
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
build-log.txt
|
50.3 KB |
|
|
ios-build-log.txt
|
145 KB |
|