Sync: Send pixels for account removal + decoding issues #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
commented
Nov 11, 2024
| do { | ||
| try updateAccount(account) | ||
| } catch { | ||
| dependencies.errorEvents.fire(.failedToSetupEngine, error: error) | ||
| } | ||
| } | ||
|
|
||
| private func updateAccount(_ account: SyncAccount? = nil) throws { | ||
| guard account?.state != .initializing else { | ||
| private func updateAccount(_ account: SyncAccount) throws { |
There was a problem hiding this comment.
Differentiating this from account removal to:
- Enforce giving a reason for reporting
- Prevent propagating nil values resulting in account removal
Bunn
approved these changes
Nov 11, 2024
mgurgel
pushed a commit
that referenced
this pull request
Nov 18, 2024
Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1201493110486074/1208723035104886/f iOS PR: duckduckgo/iOS#3557 macOS PR: duckduckgo/macos-browser#3530 What kind of version bump will this require?: Minor **Description**: Adds sync errors for catching when the keychain read throws a decoding error and when the account is deleted for various reasons **Steps to test this PR**: 1. Make sure you've already activated sync. 2. Deactivate sync (either delete the server data or just turn it off) 3. You should see the `sync_account_removed_reason_user-turned-off` pixel in the console. **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1201493110486074/1208723035104886/f
iOS PR: duckduckgo/iOS#3557
macOS PR: duckduckgo/macos-browser#3530
What kind of version bump will this require?: Minor
Description:
Adds sync errors for catching when the keychain read throws a decoding error and when the account is deleted for various reasons
Steps to test this PR:
sync_account_removed_reason_user-turned-offpixel in the console.OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template