Tracking pixels for content blocking fetch and lookup #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
studiosutara
force-pushed
the
smodi/content_blocking_lookup_time_tracking
branch
2 times, most recently
from
258f999 to
0961198
Compare
studiosutara
changed the title
bwaresiak
reviewed
Nov 25, 2024
| @@ -377,6 +388,9 @@ public class ContentBlockerRulesManager: CompiledRuleListsSource { | |||
| unprotectedSitesHash: nil)) | |||
| } | |||
|
|
|||
| // if task is main tds task, extract time and iteration count from the result and fire the pixel | |||
| // can result be a struct? can we add fields to compliatiotask instead? | |||
| // can we sen dpixels from compialtion task? | |||
There was a problem hiding this comment.
I think this is not an intended change :)
studiosutara
commented
Nov 25, 2024
| XCTAssertEqual(mockLastCompiledRulesStore.rules.first?.name, mockRulesSource.ruleListName) | ||
| XCTAssertEqual(mockLastCompiledRulesStore.rules.first?.trackerData, mockRulesSource.trackerData?.tds) | ||
| XCTAssertEqual(mockLastCompiledRulesStore.rules.first?.identifier, newIdentifier) | ||
| if expRecompiled.currentFulfillmentCount == 1 { // finished compilation after cold start (using last compiled rules) |
There was a problem hiding this comment.
This was not needed for my work, but I noticed that code wasn’t getting called. I moved it up into the block. Please check that this is correct.
studiosutara
force-pushed
the
smodi/content_blocking_lookup_time_tracking
branch
from
be2cbbb to
0f82487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1208613456171888/1208801514911204/f
iOS PR: duckduckgo/iOS#3597
macOS PR:
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL:
CC:
Description:
Steps to test this PR:
1.
1.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template