Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actor isolation for SubscriptionFeatureMappingCache #1113

Merged
merged 1 commit into from
Dec 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Sources/Subscription/SubscriptionFeatureMappingCache.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,11 @@ public protocol SubscriptionFeatureMappingCache {
func subscriptionFeatures(for subscriptionIdentifier: String) async -> [Entitlement.ProductName]
}

public final class DefaultSubscriptionFeatureMappingCache: SubscriptionFeatureMappingCache {
public actor DefaultSubscriptionFeatureMappingCache: SubscriptionFeatureMappingCache {

private let subscriptionEndpointService: SubscriptionEndpointService
private let userDefaults: UserDefaults

private var subscriptionFeatureMapping: SubscriptionFeatureMapping?

public init(subscriptionEndpointService: SubscriptionEndpointService, userDefaults: UserDefaults) {
self.subscriptionEndpointService = subscriptionEndpointService
self.userDefaults = userDefaults
Expand Down Expand Up @@ -96,7 +94,7 @@ public final class DefaultSubscriptionFeatureMappingCache: SubscriptionFeatureMa

static private let subscriptionFeatureMappingKey = "com.duckduckgo.subscription.featuremapping"

dynamic var storedFeatureMapping: SubscriptionFeatureMapping? {
var storedFeatureMapping: SubscriptionFeatureMapping? {
get {
guard let data = userDefaults.data(forKey: Self.subscriptionFeatureMappingKey) else { return nil }
do {
Expand Down
Loading