Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VPNSettings for cohort storage #581

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Nov 29, 2023

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1205948683470036/f
iOS PR: duckduckgo/iOS#2207
macOS PR: duckduckgo/macos-browser#1905
What kind of version bump will this require?: Minor

Description:

Stores the netP cohort value inside VPNSettings so that it can be accessed by both the system extension and the VPN.

Steps to test this PR:

See platform-specific PRs.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@quanganhdo quanganhdo marked this pull request as ready for review November 29, 2023 19:16
@quanganhdo quanganhdo requested a review from samsymons November 29, 2023 19:16
@quanganhdo quanganhdo self-assigned this Nov 29, 2023
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quanganhdo quanganhdo merged commit 8e77b5a into main Dec 1, 2023
5 checks passed
@quanganhdo quanganhdo deleted the anh/netp-active-new-pixels branch December 1, 2023 14:03
samsymons added a commit that referenced this pull request Dec 1, 2023
* main:
  Use VPNSettings for cohort storage (#581)
samsymons added a commit that referenced this pull request Dec 4, 2023
* main:
  Don't include port in server address (#583)
  Use VPNSettings for cohort storage (#581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants