Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckplayer): bump CSS for duckplayer nav loop fix #602

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Dec 18, 2023

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1206197024515456/f
iOS PR:
macOS PR: duckduckgo/macos-browser#1982
What kind of version bump will this require?: Major/Minor/Patch

Optional:

Tech Design URL:
CC:

Description:

Steps to test this PR:
1.
1.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@shakyShane
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@shakyShane shakyShane requested a review from ayoy December 18, 2023 17:24
Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! works as expected can you rebase? since there have been other releases meanwhile and it doesn’t work with iOS

@shakyShane shakyShane force-pushed the shane/duckplayer-nav-loop branch from 2410d19 to 0fa8c96 Compare January 5, 2024 07:04
@shakyShane shakyShane merged commit f2b6a76 into main Jan 5, 2024
9 checks passed
@shakyShane shakyShane deleted the shane/duckplayer-nav-loop branch January 5, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants