-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup after rolling out autoconsent enabled by default #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amddg44
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😄
samsymons
added a commit
that referenced
this pull request
Mar 8, 2024
* main: Changes to 114.1.0-1 hotfix branch (#706) Navigation: Improve same-document navigation handling (#702) Add pixels for our main VPN funnels (#698) Remove Autoconsent subfeature (#697) #URL macro (#657) Handle expired entitlement in NetP (#692) Remove isSubscriptionEnabled check when attempting to delete NetP token (#701) Remove CGNAT range. (#691) Subscription keychain sharing for access token (#690) Integrate confirm entitlements endpoint (#700) fix bundle name in breakByRaisingSigInt (#699) Adds support for deleting all logins (#672) Bump C-S-S to 5.2.0 (#695) Update xcode-version to 15.2. (#688) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#687)
dus7
added a commit
that referenced
this pull request
Mar 15, 2024
afterxleep
pushed a commit
that referenced
this pull request
Mar 15, 2024
samsymons
added a commit
that referenced
this pull request
Mar 18, 2024
samsymons
added a commit
that referenced
this pull request
Mar 18, 2024
* main: Update wireguard-apple to 1.1.3. (#729) Improves VPN pixel info and adds tests (#732) Reset Cache on Subscription Purchase & Restore (#719) Revert "Remove Autoconsent subfeature (#697)" (#730) Stub objects for Bookmarks sync (#713) make history entry weak to avoid retain cycle (#727) NetP x Subscription Clean-up (#709) Moves AppLaunching out of BSK as it's macOS only (#721)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1206264112133008/1206441936959052/f
iOS PR: duckduckgo/iOS#2537
macOS PR: duckduckgo/macos-browser#2316
What kind of version bump will this require?: Major
Description:
Removes onByDefault rollout subfeature. See duckduckgo/iOS#2537 for details.
Steps to test this PR:
See respective platform PRs
Internal references:
Software Engineering Expectations
Technical Design Template