Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after rolling out autoconsent enabled by default #697

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Mar 5, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1206264112133008/1206441936959052/f
iOS PR: duckduckgo/iOS#2537
macOS PR: duckduckgo/macos-browser#2316
What kind of version bump will this require?: Major

Description:

Removes onByDefault rollout subfeature. See duckduckgo/iOS#2537 for details.

Steps to test this PR:
See respective platform PRs


Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 self-assigned this Mar 5, 2024
@dus7 dus7 marked this pull request as ready for review March 5, 2024 10:18
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@dus7 dus7 merged commit 2181cdc into main Mar 7, 2024
7 checks passed
@dus7 dus7 deleted the mariusz/cleanup-cpm-default branch March 7, 2024 08:47
samsymons added a commit that referenced this pull request Mar 8, 2024
* main:
  Changes to 114.1.0-1 hotfix branch (#706)
  Navigation: Improve same-document navigation handling (#702)
  Add pixels for our main VPN funnels (#698)
  Remove Autoconsent subfeature (#697)
  #URL macro (#657)
  Handle expired entitlement in NetP (#692)
  Remove isSubscriptionEnabled check when attempting to delete NetP token (#701)
  Remove CGNAT range. (#691)
  Subscription keychain sharing for access token (#690)
  Integrate confirm entitlements endpoint (#700)
  fix bundle name in breakByRaisingSigInt (#699)
  Adds support for deleting all logins (#672)
  Bump C-S-S to 5.2.0 (#695)
  Update xcode-version to 15.2. (#688)
  Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#687)
dus7 added a commit that referenced this pull request Mar 15, 2024
dus7 added a commit that referenced this pull request Mar 15, 2024
afterxleep pushed a commit that referenced this pull request Mar 15, 2024
samsymons added a commit that referenced this pull request Mar 18, 2024
* main:
  Improves VPN pixel info and adds tests (#732)
  Reset Cache on Subscription Purchase & Restore (#719)
  Revert "Remove Autoconsent subfeature (#697)" (#730)
  Stub objects for Bookmarks sync (#713)
samsymons added a commit that referenced this pull request Mar 18, 2024
* main:
  Update wireguard-apple to 1.1.3. (#729)
  Improves VPN pixel info and adds tests (#732)
  Reset Cache on Subscription Purchase & Restore (#719)
  Revert "Remove Autoconsent subfeature (#697)" (#730)
  Stub objects for Bookmarks sync (#713)
  make history entry weak to avoid retain cycle (#727)
  NetP x Subscription Clean-up (#709)
  Moves AppLaunching out of BSK as it's macOS only (#721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants