Report Autofill failures #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amddg44
commented
Jul 22, 2024
| valueDataKey: "com.duckduckgo.UserDefaultExpiryStorage.valueData" | ||
| ) | ||
|
|
||
| public static let autofillConfig = ExpiryStorageConfiguration( |
There was a problem hiding this comment.
Created Autofill specific storage keys so that broken site reports and autofill breakage reports are stored separately
amddg44
commented
Jul 22, 2024
| } | ||
|
|
||
| /// Report the site breakage | ||
| public func report(_ report: BrokenSiteReport, reportMode: BrokenSiteReport.Mode) throws { | ||
| public func report(_ report: BrokenSiteReport, reportMode: BrokenSiteReport.Mode, daysToExpiry: Int = 30) throws { |
There was a problem hiding this comment.
Added daysToExpiry here since it will dynamic for autofill reports depending on the privacy config defined value
graeme
approved these changes
Jul 23, 2024
samsymons
added a commit
that referenced
this pull request
Jul 29, 2024
samsymons
added a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1201462886803403/1207504090894693/f
iOS PR: duckduckgo/iOS#3116
macOS PR: duckduckgo/macos-browser#3004
What kind of version bump will this require?: Patch
Description:
Allows users to submit autofill breakage reports
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template