-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules for Pubtech (CMP) #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just needs some polishing :)
you can also find more test examples on https://publicwww.com/websites/%22pubtech-cmp%22/
@muodov it's good to be reviewed. |
@muodov I made some corrections and left a comment about the potential risk for the buttons to switch order and asked if we should park this project under the autogenerated selectors websites. Comment here: #25 (comment) Also not sure I understand your comment on the "OR" and parenthesis. Otherwise self, local and jenkins tests are all passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking better! Just a couple of changes and should be good to go
@muodov made the changes requested (conditional rule for OptIn and the eval logic). Some whitespace in the optIn rule needed to becommitted which explains the third commit. Passed: Self-test, local test & jenkins job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙏
Add rules about: www.liberoquotidiano.it <- CMP Pubtech autogenerated