Fix unwrapping of eval result array. #33
Conversation
sammacbeth
force-pushed
the
sam/ff-eval-bug
branch
from
e15442e to
e3fa67d
Compare
| resolve([{ | ||
| result, | ||
| result: resultArr[0], |
There was a problem hiding this comment.
@sammacbeth looks good I think, so since we're converting the "eval" result to a boolean value I guess we can be sure we'll always get back exactly one result in MV3, if I understand the docs correctly?
There was a problem hiding this comment.
This code path is only for MV2, which returns an array.
addon/background.ts
Outdated
| @@ -106,7 +106,7 @@ chrome.runtime.onMessage.addListener( | |||
| case "eval": | |||
| evalInTab(tabId, frameId, msg.code).then(([result]) => { | |||
| if (enableLogs) { | |||
| console.groupCollapsed(`eval result for ${sender.origin}`); | |||
| console.groupCollapsed(`eval result for ${sender.origin || new URL(sender.url).origin}`); | |||
There was a problem hiding this comment.
Are we sure that either sender.origin or sender.urlwill always be defined? I checked the (docs)[https://developer.chrome.com/docs/extensions/reference/runtime/#type-MessageSender] and both seem optional, though probably one needs to be set, I guess, @sammacbeth?
There was a problem hiding this comment.
I think you always get one, but I removed the use of URL to be safe and prevent an error being thrown here.
sammacbeth
force-pushed
the
sam/ff-eval-bug
branch
from
e3fa67d to
f05fd00
Compare
Fixes an error in manifest v2 extensions where we were returning a result array for eval rules, which is truthy, causing rules to trigger too often.