Add extra options for Jenkins to improve test reliability. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sammacbeth
commented
Nov 11, 2022
sammacbeth
commented
- Test parameter to specific a browser to test on.
- Test parameter to run tests with grep (to get a quick result for a given CMP/site).
- Reduce workers, so we have fewer issues when running two jobs simultaneously on once instance.
sammacbeth
added
patch
sammacbeth
force-pushed
the
sam/jenkins
branch
from
0f18c13 to
020c34d
Compare
adewes
reviewed
Nov 17, 2022
There was a problem hiding this comment.
Thanks @sammacbeth, I'm not very familiar with Jenkinsfile and I don't have a way to test this locally. Reading the changes they make sense to me and I guess we'll see immediately if they break something in Jenkins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.