(DomActions) WTR tests for elementSelector() #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freiondrej
commented
Oct 14, 2024
freiondrej
commented
Oct 14, 2024
freiondrej
commented
Oct 14, 2024
muodov
reviewed
Oct 15, 2024
There was a problem hiding this comment.
This is great @freiondrej! I just had a couple minor remarks. Thank you for doing this!
| ]) | ||
| }) | ||
| }) | ||
| describe('querySelectorChain', () => { |
There was a problem hiding this comment.
could you add a test for Shadow DOM? something for ['.my-shadow-root-selector', '.selector-inside-shadow-root']?
There was a problem hiding this comment.
good call! I'll adjust the should return elements by querySelectorAll from shadow root if available which now cannot be used directly anymore as the elementSelector() only accepts one argument.
|
@freiondrej do you want to follow up here? |
Yes, absolutely :) I just didn't have a free evening yet, apologies. |
This was referenced Oct 21, 2024
muodov
added
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @muodov, will it bring value to continue covering DomActions like this? I can try to send a PR every now and then :) or pls point me to some higher-value task 🙏