New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an ESLint rule to prevent private methods for now. #620

Merged

jonathanKingston merged 1 commit into main from jkt/preventPrivateMethods

Jul 10, 2023

Contributor

jonathanKingston commented Jul 10, 2023 •

edited

Loading

Rule to prevent the breakage being fixed in #617 that has happened a few times now.

I looked into other setups like https://github.com/amilajack/eslint-plugin-compat but they only appear to cover DOM APIs and have some concerning shortcomings so I just concentrated on the issue at hand here.

Prior to #617 the lint rule looks like this:


          Add an ESLint rule to prevent private methods for now.

b20f0c6

jonathanKingston requested a review from shakyShane as a code owner

July 10, 2023 18:34

shakyShane approved these changes

View reviewed changes

jonathanKingston merged commit 50eb0d7 into main

jonathanKingston deleted the jkt/preventPrivateMethods branch

July 10, 2023 18:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet