-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scanner] Don't stop scanner fully on max forms #617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajpeyi
force-pushed
the
dbajpeyi/scan-sites-on-click
branch
4 times, most recently
from
July 24, 2024 03:41
0f632bf
to
94dada9
Compare
dbajpeyi
force-pushed
the
dbajpeyi/scan-sites-on-click
branch
from
July 24, 2024 03:46
94dada9
to
ee21936
Compare
dbajpeyi
changed the title
feat: don't stop scanner fully on max forms
[Scanner] Don't stop scanner fully on max forms
Jul 24, 2024
dbajpeyi
force-pushed
the
dbajpeyi/scan-sites-on-click
branch
from
July 24, 2024 04:15
76b59a1
to
923bf77
Compare
dbajpeyi
commented
Jul 24, 2024
dbajpeyi
force-pushed
the
dbajpeyi/scan-sites-on-click
branch
from
July 24, 2024 05:24
1362c8a
to
43eedad
Compare
shakyShane
approved these changes
Jul 26, 2024
This was referenced Jul 29, 2024
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Aug 2, 2024
Task/Issue URL: https://app.asana.com/0/1207920271697429/1207920271697429 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.1.0 ## Description Updates Autofill to version [12.1.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.1.0). ### Autofill 12.1.0 release notes ## What's Changed * [Form] Skip autofilling select input if it was changed already by @dbajpeyi in duckduckgo/duckduckgo-autofill#580 * scanner: discard Form instances with no classified inputs by @sjbarag in duckduckgo/duckduckgo-autofill#574 * [Credentials] Autofill when elements are in shadow by @dbajpeyi in duckduckgo/duckduckgo-autofill#592 * Update password-related json files (2024-07-19) by @daxmobile in duckduckgo/duckduckgo-autofill#607 * [Scanner] Don't stop scanner fully on max forms by @dbajpeyi in duckduckgo/duckduckgo-autofill#617 * tests: remove spurious logging from unit tests by @sjbarag in duckduckgo/duckduckgo-autofill#575 * Add credit card test form failure by @GioSensation in duckduckgo/duckduckgo-autofill#588 ## New Contributors * @dbajpeyi made their first contribution in duckduckgo/duckduckgo-autofill#580 **Full Changelog**: duckduckgo/duckduckgo-autofill@12.0.1...12.1.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: GioSensation <1828326+GioSensation@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane @GioSensation
Asana: https://app.asana.com/0/0/1207840563867787/f
Description
Originally, #574 fixed an issue that destructed forms if it didn't have enough eligible inputs that could be filled out. This way such forms won't take up the form pool (of max 30 forms), and avoid getting into a situation where an actually useful form won't get into the pool. However, the PR also introduced a problem that if there were many lonely inputs (e.g in ~60 this test form), the scanner created forms that self destructed over and over again.
This PR tries a different approach:
scanShadow
->scanOnClick
and extends it to not only work for elements within shadow trees, but also general inputs that might need to be scanned again.stopScanner
so that it can take an additional param that allows keeping form listeners,Steps to test
Originally reported sites: https://scanmalta.com/shop