Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout of 'Learn more' link #2171

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

imsoumya18
Copy link
Contributor

This is a fix to Issue#1029

@sammacbeth sammacbeth changed the title Issue#1029 Fix layout of 'Learn more' link Aug 23, 2023
@sammacbeth
Copy link
Collaborator

Thanks for this PR! Testing locally, there seems to be a bit too much padding around the link in Chrome. Could to try and make the padding match the Fire button link?
Screenshot 2023-08-23 at 12 29 19

@imsoumya18
Copy link
Contributor Author

Sure, I shall go through it

@imsoumya18
Copy link
Contributor Author

@sammacbeth please review the 2nd PR I have created. I have fixed the padding

Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! Looks good now.

@sammacbeth sammacbeth merged commit 49936cc into duckduckgo:main Aug 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants