Skip to content

Ship review feedback - Color + Orientation (#3715) #9728

Ship review feedback - Color + Orientation (#3715)

Ship review feedback - Color + Orientation (#3715) #9728

Triggered via push December 11, 2024 14:55
Status Success
Total duration 12m 9s
Artifacts

pr.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

24 warnings and 10 notices
ShellCheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Unit Tests
xcbeautify 2.15.0 is already installed and up-to-date. To reinstall 2.15.0, run: brew reinstall xcbeautify
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: Core/StatisticsLoader.swift#L80
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L102
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L148
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L178
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/Pixel.swift#L275
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
Unit Tests
Accent color ‘AccentColor’ is not present in any asset catalogs.
Unit Tests
Background color ‘WidgetBackground’ is not present in any asset catalogs.
Unit Tests: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L37
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L275
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L80
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L102
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L148
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L178
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L275
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L80
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build
xcbeautify 2.15.0 is already installed and up-to-date. To reinstall 2.15.0, run: brew reinstall xcbeautify
Unit Tests
Skipped UnitTests.AutofillLoginListViewModelTests.testWhenBreakageReporterConfigEnabledAndReportAlreadyRecentlySavedThenShowBreakageReporterIsFalse
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenCallActionOnOnboardingFinalDialog_ThenDidTapDismissContextualOnboardingActionOnDelegateIsCalled
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewFire_ThenReturnViewOnboardingFireDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasNotShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForFinalSpec_ThenReturnViewOnboardingFinalDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasNotShown_ThenActionCallsDidAcknowledgeContextualOnboardingTrackersDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasShown_ThenActionCallsDidTapDismissContextualOnboardingAction
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_ThenReturnViewOnboardingTrackersDoneDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForVisitWebsiteSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenNavigateToActionIsCalledOnDelegate