Skip to content

Commit

Permalink
Reduce number of buckets for open tabs daily pixel (#3663)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1206226850447395/1208866352354120/f
Tech Design URL:
CC:

**Description**:

Reduces the temporary high granularity of opened tabs buckets.

**Steps to test this PR**:
1. Verify the validity of unit tests for daily open tabs pixel and
whether they pass.

**Definition of Done (Internal Only)**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
  • Loading branch information
dus7 authored Dec 16, 2024
1 parent 4d78d09 commit 24c093e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
7 changes: 1 addition & 6 deletions DuckDuckGo/TabSwitcherOpenDailyPixel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,7 @@ struct TabSwitcherOpenDailyPixel {
case 21...40: return "21-40"
case 41...60: return "41-60"
case 61...80: return "61-80"
case 81...100: return "81-100"
case 101...125: return "101-125"
case 126...150: return "126-150"
case 151...250: return "151-250"
case 251...500: return "251-500"
default: return "501+"
default: return "81+"
}

}
Expand Down
8 changes: 2 additions & 6 deletions DuckDuckGoTests/TabSwitcherOpenDailyPixelTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,8 @@ final class TabSwitcherOpenDailyPixelTests: XCTestCase {
21...40: "21-40",
41...60: "41-60",
61...80: "61-80",
81...100: "81-100",
101...125: "101-125",
126...150: "126-150",
151...250: "151-250",
251...500: "251-500",
501...504: "501+"]
81...90: "81+",
501...504: "81+"]

for bucket in bucketValues {
for value in bucket.key {
Expand Down

0 comments on commit 24c093e

Please sign in to comment.