Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch ‘coldfix/7.93.0' #2095

Closed
wants to merge 2 commits into from
Closed

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Oct 13, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205691418983706
https://app.asana.com/0/246491496396031/1205693429987634

Description:

This is mainly to bump the release version as I just merged the cherry-picks to the release branch without doing this. The PRs have been reviewed already in #2085 and #2084.

Steps to test this PR:

See linked tasks, but this has already been reviewed and tested in the previous PRs

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

graeme and others added 2 commits October 10, 2023 18:17
Co-authored-by: Tom Strba <57389842+tomasstrba@users.noreply.github.com>
Co-authored-by: David Harbage <dave@duckduckgo.com>
Co-authored-by: Dax Mobile <44842493+daxmobile@users.noreply.github.com>
Co-authored-by: GioSensation <GioSensation@users.noreply.github.com>
@graeme graeme closed this Oct 13, 2023
@graeme graeme deleted the coldfix/7.93.0 branch October 13, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant