Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test to match exact tracker #2133

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1205237866452338/1205902260676401/f
Tech Design URL:
CC:

Description:

Update URL in tests to reflect latest blocking rules.

Steps to test this PR:

Validate tests.


Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this change was intentional, LGTM

@bwaresiak bwaresiak force-pushed the bartek/fix_cb_tests branch from 9453b4f to 48654e6 Compare November 8, 2023 10:59
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's even better. thanks

@bwaresiak bwaresiak merged commit fbcd0d4 into develop Nov 8, 2023
9 checks passed
@bwaresiak bwaresiak deleted the bartek/fix_cb_tests branch November 8, 2023 11:12
samsymons added a commit that referenced this pull request Nov 9, 2023
# By Christopher Brind (3) and others
# Via GitHub (1) and Michal Smaga (1)
* develop:
  Support environment setting (#2140)
  Update BSK (#2136)
  Update BSK for NetP change (#2134)
  Update test to match exact tracker (#2133)
  Avoid AppTP DB initialization when disabled (#2090)
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Nov 10, 2023
* develop:
  Support environment setting (#2140)
  Update BSK (#2136)
  Update BSK for NetP change (#2134)
  Update test to match exact tracker (#2133)
  Avoid AppTP DB initialization when disabled (#2090)
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants