Autofill pixel parameter removed #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amddg44
requested review from
a team and
jotaemepereira
and removed request for
a team
jotaemepereira
approved these changes
Nov 27, 2023
samsymons
added a commit
that referenced
this pull request
Nov 29, 2023
# By Anh Do (1) and others # Via Bartek Waresiak (2) and GitHub (1) * develop: update theme to use system colours (#2180) Release 7.99.0 (#2205) Update iOS privacy defaults (#2185) Remove disabled switches from VPN Settings screen (#2203) Update BSK for VPN settings (#2165) Fix migrating from Bookmarks V2 and older (#2196) Autofill pixel parameter removed (#2182) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Dec 5, 2023
* develop: (40 commits) Address Bar Spoofing Tests + Remediation (#2181) Update Sync e2e tests to fit the new UI (#2215) NetP waitlist final touches (#2209) NetP: Remove port from server address (#2214) NetP: Fix list row colours (#2213) Reset VPN waitlist T&C (#2212) Report macOS active/new user for netP (#2207) Sabrina/sync setup update (#2198) new pixels for toolbars and share sheet (#2208) Use design system fonts throughout NetP (#2211) moving the toggle to the top of the dashboard (#2166) Allow automated fetching of synced bookmarks' favicons (#2163) NetP Geoswitching Design Review feedback (#2206) update theme to use system colours (#2180) Release 7.99.0 (#2205) Update iOS privacy defaults (#2185) Remove disabled switches from VPN Settings screen (#2203) Update BSK for VPN settings (#2165) Fix migrating from Bookmarks V2 and older (#2196) Autofill pixel parameter removed (#2182) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205278999335242/1205495150811779/f
Tech Design URL:
CC:
Description:
Removes the parameter which distinguishes between the default on or off state of the autofill setting now that new installs are set to enabled by default.
Steps to test this PR:
Run through the various Autofill actions to trigger the pixels from this list and confirm that they no longer have the
default_stateparameter. https://fill.dev/ is a useful site for testingPrompt to disable setting:
To test this, start with a clean install and Autofill enabled. Visit 2 different websites that have a login option and attempt to login to each. For each Save Prompt choose "Not Now". After the 2rd "Not Now" you'll be presented with the alert that fires these pixels:
m_autofill_logins_save_disable-prompt_shownm_autofill_logins_save_disable-prompt_autofill-kept(tappingKeep Saving)m_autofill_logins_save_disable-prompt_autofill-disabled(tappingDisable)Save login prompt:
Visit https://fill.dev/form/login-simple and enter some credentials to trigger the prompt
m_autofill_logins_save_login_inline_displayedm_autofill_logins_save_login_inline_confirmed(TappingSave Password)m_autofill_logins_save_login_inline_dismissed(TappedXat top right or swipe down)m_autofill_logins_save_login_exclude_site_confirmed(TappingNever Ask for This Site)Save password prompt:
(https://news.ycombinator.com/login is a useful site to test triggering the password only save prompt - in the login form enter only a password and tap login to trigger)
m_autofill_logins_save_password_inline_displayedm_autofill_logins_save_password_inline_confirmedm_autofill_logins_save_password_inline_dismissedFill login prompt:
Visit https://fill.dev/form/login-simple and use credentials saved from
Save login promptstepm_autofill_logins_fill_login_inline_autoprompt_displayed(autoprompt triggered when fill login prompt presents automatically)m_autofill_logins_fill_login_inline_autoprompt_confirmedm_autofill_logins_fill_login_inline_manual_displayed(manual pixels triggered when tapping the key icon)m_autofill_logins_fill_login_inline_manual_confirmedm_autofill_logins_fill_login_inline_manual_dismissedm_autofill_logins_autoprompt_dismissedOpening and toggling autofill logins setting:
m_autofill_settings_opened(Triggered by accessing Logins from Settings screen)m_nav_autofill_menu_item_pressed(Triggered by accessing Logins from browsing menu)m_autofill_logins_settings_enabledm_autofill_logins_settings_disabledPassword generation prompts:
Visit https://fill.dev/form/registration-email and tap the key icon in the password field
m_autofill_logins_password_generation_prompt_displayedm_autofill_logins_password_generation_prompt_confirmedm_autofill_logins_password_generation_prompt_dismissedInternal references:
Software Engineering Expectations
Technical Design Template