Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply container background widgets [needs Xcode 15] #2229

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Dec 6, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205862739369423/f
Tech Design URL:
CC:

Description:

When building with Xcode 15 the widgets require a container background.

Steps to test this PR:

  1. Build and run the app using Xcode 15
  2. Add all the widgets to the Home Screen and confirm they render correctly
  3. Add Lock Screen widgets and confirm they render correctly

@brindy brindy requested a review from samsymons December 6, 2023 16:15
@brindy brindy changed the title apply container background to xcode15 widgets apply container background widgets [needs Xcode 15] Dec 6, 2023
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good, and in the simulator this looks good, but for some reason all widgets are blank on a physical device, even after rebooting. Are you seeing the same thing @brindy?

Blank Widgets

@brindy brindy assigned brindy and unassigned brindy Dec 7, 2023
@brindy
Copy link
Contributor Author

brindy commented Dec 7, 2023

It definitely worked when I first did it. Just going to try on Xcode 15.0.0 locally. Maybe it's the point release has broken it?

Edit: Yep - "works for me" on Xcode 15 and Xcode 15.0.1 🤷

@brindy brindy self-assigned this Jan 2, 2024
@brindy
Copy link
Contributor Author

brindy commented Jan 9, 2024

Gave them a quick test with Xcode 15.1 and still good.

@brindy brindy merged commit cac0314 into main Jan 9, 2024
10 checks passed
@brindy brindy deleted the brindy/xcode15-widgets branch January 9, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants