Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Geoswitching pixels #2235

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Add Geoswitching pixels #2235

merged 4 commits into from
Dec 6, 2023

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Dec 6, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1206107031155633/f

Description:

Adds the Pixels described in the parent of the linked PR task to monitor Geoswitching during the Waitlist beta

Steps to test this PR:

  1. Run the app in the debugger
  2. Make sure you’re an internal user and you’ve used an invite code to access NetP
  3. Go to Settings -> Network Protection -> VPN Settings -> VPN Location
  4. You should see the Pixel for opening Geoswitching in the debugger
  5. Select a location
  6. ** You should see the Pixel for selecting custom int the debugger
  7. Select Nearest
  8. ** You should see the Pixel for selecting nearest in the debugger
  9. There is also a pixel for if there is no list returned. Perhaps get creative with how you test that, but my guess is we won’t get many of these due to the fact they’ll be most likely to occur when offline.

@graeme graeme self-assigned this Dec 6, 2023
@graeme graeme requested a review from samsymons December 6, 2023 16:52
@graeme graeme marked this pull request as ready for review December 6, 2023 16:53
@graeme graeme merged commit 315a147 into main Dec 6, 2023
10 checks passed
@graeme graeme deleted the graeme/geoswitching-pixels branch December 6, 2023 18:19
samsymons added a commit that referenced this pull request Dec 6, 2023
@samsymons
Merge branch 'main' into diego/fix-vpn-dns-routing
1b1a015 
# By Graeme Arthur
# Via GitHub
* main:
  Add Geoswitching pixels (#2235)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Dec 7, 2023
@samsymons
Merge branch 'main' into sam/use-manual-signing-for-development
3a776ee 
* main:
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  Update BSK reference to include the disable rekeying flag (#2219)
  Final NetP ship review feedback (#2221)
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)
samsymons added a commit that referenced this pull request Dec 7, 2023
@samsymons
Merge branch 'main' into jacek/xcode15
7a8f19e 
# By Graeme Arthur (3) and others
# Via GitHub
* main:
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  Update BSK reference to include the disable rekeying flag (#2219)
  Final NetP ship review feedback (#2221)
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)

# Conflicts:
#	DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo.xcscheme
samsymons added a commit that referenced this pull request Dec 9, 2023
@samsymons
Merge branch 'main' into sam/enable-netp-in-production
d041c90 
* main:
  Report macOS NetP connection attempts & tunnel failures (#2234)
  Always use black and white colors for the QR code (#2248)
  Update BSK with autofill 10.0.1 (#2245)
  Ensure that LinkPresentation framework is called on main thread (#2241)
  expose window.print handler to page world (#2243)
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
samsymons added a commit that referenced this pull request Dec 11, 2023
@samsymons
Merge branch 'main' into sam/fix-fingerprinting-tests
ceb69d7 
* main:
  Enable NetP in production builds (#2232)
  Report macOS NetP connection attempts & tunnel failures (#2234)
  Always use black and white colors for the QR code (#2248)
  Update BSK with autofill 10.0.1 (#2245)
  Ensure that LinkPresentation framework is called on main thread (#2241)
  expose window.print handler to page world (#2243)
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  Update BSK reference to include the disable rekeying flag (#2219)
  Final NetP ship review feedback (#2221)
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)
  Address Bar Spoofing Tests + Remediation (#2181)
  Update Sync e2e tests to fit the new UI (#2215)
  NetP waitlist final touches (#2209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsymons samsymons samsymons approved these changes

Assignees

@graeme graeme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graeme @samsymons