Subscriptions Base Implementation #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo/AddressBarPositionSettingsViewController.swift # DuckDuckGo/MainViewController+Segues.swift # DuckDuckGo/UserText.swift
afterxleep
changed the base branch from
daniel/settings-swiftui
to
daniel/subscriptions/integration
afterxleep
changed the base branch from
daniel/subscriptions/integration
to
main
afterxleep
changed the base branch from
main
to
daniel/subscriptions/integration
afterxleep
changed the base branch from
daniel/subscriptions/integration
to
main
…adless-webview # Conflicts: # Core/FeatureFlag.swift # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Base.lproj/Settings.storyboard # DuckDuckGo/Debug.storyboard # DuckDuckGo/SettingsViewController.swift # DuckDuckGo/UserText.swift
# Conflicts: # DuckDuckGo/nb.lproj/Settings.strings
miasma13
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Works as expected, just two minor comments:
- I think it is safer to avoid in naming of things usage of branding name "PrivacyPro" and instead use generic "Subscription" word.
- In the "Privacy Pro" section within "Settings" the "Learn More" button seems to hijack taps and requires user to tap on the cell background to trigger the navigation action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1205054784245717
Description
How to test
Note:
Settings page will NOT reflect subscribed services yet. That's coming up in the next PR.
Internal references:
Software Engineering Expectations
Technical Design Template