Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect system theme on launch #2302

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jan 4, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1206169242570089/f
Tech Design URL:
CC:

Description:
Use system colours in the launch storyboard (for now).

Steps to test this PR:

  1. Set system theme to light. Launch the app. Launch screen background should be white and text should be readable.
  2. Set system theme to dark. Launch the app. Launch screen background should be black and text should be readable.

@brindy brindy requested review from a team and tomasstrba and removed request for a team January 4, 2024 10:25
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! ✅ This is literally a quick win! 👏

@brindy brindy merged commit d7a6661 into main Jan 5, 2024
10 checks passed
@brindy brindy deleted the brindy/fix-white-screen-on-startup branch January 5, 2024 11:24
samsymons added a commit that referenced this pull request Jan 8, 2024
* main:
  deps BrowserServicesKit 100.0.3 + content-scope-scripts 4.59.0 (#2304)
  bookmarks migration refactor (#2236)
  respect system theme on launch (#2302)
  remove unused pixels (#2303)
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2285)
  Update Sync End-to-End tests (#2300)
  Allow calculations in the address bar (#2298)
  Remove trailing space in unableToCreateRecoveryPDF error (#2297)
  Update errors (#2283)
  BSK update for autofill never prompt to save for site feature (#2280)
  Add timeouts to the alpha job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants