Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GRDB.swift 2.23.0 (upstream 6.32.0, SQLCipher 4.5.5) #2305

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jan 5, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1206287402354150/f

Description:
Use the latest version of GRDB.

Steps to test this PR:
Smoke test autofill.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Jan 5, 2024
@ayoy ayoy marked this pull request as ready for review January 5, 2024 13:48
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autofill works as expected.

@ayoy ayoy merged commit 0eb447c into main Jan 12, 2024
10 checks passed
@ayoy ayoy deleted the dominik/grdb-2.3.0 branch January 12, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants