Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to obtain reason why given feature is disabled #2309

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/0/1206213106333866/f
Tech Design URL:
CC:

Description:

Add API to obtain reason why given feature is disabled - needed for sync dialogs.

Steps to test this PR:
1.
2.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@bwaresiak bwaresiak force-pushed the bartek/detailed-feature-state-info branch from 756958a to 203efd1 Compare January 9, 2024 09:40
bwaresiak added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jan 9, 2024
Task/Issue URL: https://app.asana.com/0/0/1206213106333866/f
iOS PR: duckduckgo/iOS#2309
macOS PR: duckduckgo/macos-browser#2030
What kind of version bump will this require?: Major

Description:

Add API to obtain reason why given feature is disabled
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwaresiak bwaresiak merged commit 89ed900 into main Jan 9, 2024
10 checks passed
@bwaresiak bwaresiak deleted the bartek/detailed-feature-state-info branch January 9, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants