Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rollout banner #2310

Merged
merged 2 commits into from
Jan 9, 2024
Merged

add rollout banner #2310

merged 2 commits into from
Jan 9, 2024

Conversation

SabrinaTardio
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1206297687428378/f

Description: Add sync rollout banner

Steps to test this PR:

  1. Open settings and check rollout banner is present (see https://app.asana.com/0/1201493110486074/1206158510940591/f)

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio requested a review from ayoy January 9, 2024 10:25
Copy link

github-actions bot commented Jan 9, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against b1f12ef

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please merge whenever we have the copy in place. BTW, I think we may do fine without the title in the banner, but that's just my opinion.

@SabrinaTardio SabrinaTardio merged commit 5d0f013 into main Jan 9, 2024
10 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/rollout-banner branch January 9, 2024 12:53
ayoy pushed a commit that referenced this pull request Jan 11, 2024
Task/Issue URL: https://app.asana.com/0/0/1206297687428378/f

Description: Add sync rollout banner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants