Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend Sync when updating device name #2313

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jan 9, 2024

Task/Issue URL: https://app.asana.com/0/1201493110486074/1206304176229205/f

Description:
This is to prevent data sync requests being sent with an outdated authorization token.

Steps to test this PR:

  1. Enable Sync (best to test on production).
  2. Change device name a few times.
  3. Verify that you're not logged out while updating device name.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy requested a review from bwaresiak January 9, 2024 18:20
Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoy ayoy merged commit bf2ed1f into main Jan 10, 2024
10 checks passed
@ayoy ayoy deleted the dominik/sync-update-device-name branch January 10, 2024 09:43
ayoy added a commit that referenced this pull request Jan 11, 2024
Task/Issue URL: https://app.asana.com/0/1201493110486074/1206304176229205/f

Description:
This is to prevent data sync requests being sent with an outdated authorization token.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants