Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization to SyncUI package #2314

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1201493110486074/1204622631026489/f
Tech Design URL:
CC:

Description:

Add localization to SyncUI package

Steps to test this PR:

Ensure loc update and loc export scripts are running and SyncUI packages are using localized resources.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

github-actions bot commented Jan 9, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 7a9fd63

@bwaresiak bwaresiak requested a review from ayoy January 10, 2024 15:50
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the script look great to me. Thanks @bwaresiak!

@bwaresiak bwaresiak merged commit 5885677 into main Jan 10, 2024
10 checks passed
@bwaresiak bwaresiak deleted the bartek/syncui-localization branch January 10, 2024 23:57
ayoy pushed a commit that referenced this pull request Jan 11, 2024
Task/Issue URL: https://app.asana.com/0/1201493110486074/1204622631026489/f
Tech Design URL:
CC:

Description:

Add localization to SyncUI package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants