Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update banner colour #2318

Merged
merged 1 commit into from
Jan 10, 2024
Merged

update banner colour #2318

merged 1 commit into from
Jan 10, 2024

Conversation

SabrinaTardio
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1206297687428378/f

Description: Update banner colour

Steps to test this PR:

  1. Check how it looks in light and dark mode

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio requested a review from ayoy January 10, 2024 13:48
Copy link

Fails
🚫 DesignResourcesKit: No new colors should be added to this app.

Generated by 🚫 dangerJS against cd05fff

@SabrinaTardio SabrinaTardio merged commit a8010b1 into main Jan 10, 2024
9 of 10 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/update-sync-banner branch January 10, 2024 15:22
ayoy pushed a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants